fix(core): close AdvancedExtension serde gaps #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm working on adding more tests to verify the serialization/deserialization for each relation type |
Signed-off-by: Niels Pardon <[email protected]>
Signed-off-by: Niels Pardon <[email protected]>
nielspardon
force-pushed
the
par-adv-ext-2
branch
from
339128f to
ccb6091
Compare
this is done. ready for review |
core/src/main/java/io/substrait/relation/ProtoRelConverter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Niels Pardon <[email protected]>
Comment on lines
+190
to
+191
| protected Rel newWrite(final WriteRel rel) { | ||
| final WriteRel.WriteTypeCase relType = rel.getWriteTypeCase(); |
There was a problem hiding this comment.
Out of curiosity, why did you add the final modifier to the Write/Update/DDL relations, but not all the other relations that use this same code pattern?
There was a problem hiding this comment.
I mainly did it for the code I thought I touched to not introduce too many unrelated changes
There was a problem hiding this comment.
I see what you mean, let me update the PR to be a little more consistent
There was a problem hiding this comment.
should be more consistent now
andrew-coleman
approved these changes
Oct 27, 2025
Signed-off-by: Niels Pardon <[email protected]>
nielspardon
force-pushed
the
par-adv-ext-2
branch
from
3c4983c to
b663112
Compare
vbarua
pushed a commit
that referenced
this pull request
Oct 28, 2025
* fix(core): close AdvancedExtension serde gaps Signed-off-by: Niels Pardon <[email protected]> * fix: add test cases Signed-off-by: Niels Pardon <[email protected]> * fix: address comments Signed-off-by: Niels Pardon <[email protected]> * fix: more consistent final declaration in changed code Signed-off-by: Niels Pardon <[email protected]> --------- Signed-off-by: Niels Pardon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there are multiple gaps in the serialization and deserialization of `AdvancedExtension which I'm trying to close with this PR:
PlanProtoConverterpassExtensionProtoConvertertoRelProtoConverterProtoPlanConverterpassProtoExtensionConvertertoProtoRelConverterHasExtensioninterface toAbstractDdlRel,AbstractWriteRelRelProtoConverter,ProtoRelConverter